Thanks for the update!
Could not get the name for com_gitlab_bitfireAT__dav4jvm, Using com.gitlab.bitfireAT:dav4jvm
-
When running ./gradlew findLibraries in davx5-ose, I get
Could not get the name for com_gitlab_bitfireAT__dav4jvm, Using com.gitlab.bitfireAT:dav4jvm
looks like the information is incomplete for dav4jvm.
When I check the About/License screen, I see
Would be nice, if the library provided a proper name and a description
-
Thanks for the report. Could you make a patch for that and send us a merge request?
-
hi @devvv4ever , I’ll see what I can do. I’ll first need to read up on the topic.
-
I checked https://jitpack.io/docs/#publishing-on-jitpack but didn’t find anything how to influence the provided meta data.
@@ -105,6 +105,9 @@ class AboutActivity: AppCompatActivity() { .withLibraryModification("org_brotli__dec", Libs.LibraryFields.LIBRARY_NAME, "Brotli") .withLibraryModification("org_brotli__dec", Libs.LibraryFields.AUTHOR_NAME, "Google") + .withLibraryModification("com_gitlab_bitfireAT__dav4jvm", Libs.LibraryFields.LIBRARY_NAME, "dav4jvm") + .withLibraryModification("com_gitlab_bitfireAT__dav4jvm", Libs.LibraryFields.AUTHOR_NAME, "Ricki Hirner, Bernhard Stockmann") + .supportFragment()
would be a cheap workaround (although not complete, since description and license information are still missing).
-
@mbiebl Thanks. Should be fixed (dav4jvm info included in DAVx⁵)
-
thanks @rfc2822
I guess (some of) the strings in about_libraries.xml should be marked as not translatable -
@mbiebl They’re not in Transifex anyway
-