Thanks. I have now removed the CONTRIBUTING.md file because it didn’t useful instructions to contribute anyway. The only useful information it contained was what’s required to diagnose a problem, which I have moved to this thread.
User agent contains non-ASCII chars in some locales and causes IllegalArgumentException
amiraliakbari last edited by rfc2822
DAVdroid sets its own user agent for requests, which contains the build date. The date is formatted with
SimpleDateFormat("yyyy/MM/dd", Locale.getDefault()). The problem is that in some locales, especially
fa-IR, this format generates strings like
۲۰۱۸/۰۵/۰۵. As a result, the final user agent contains non-ASCII characters which causes IllegalArgumentException in underlying okhttp library.
I suggest using non-localized date format in user agent to fix this problem.
Thanks for the hint I didn’t have in mind that numbers (year, month, day) could have non-ASCII representations. Should be fixed with 9aa58d17.
I have sent an APK over email, please tell me whether it solves your problem.
amiraliakbari last edited by
Thanks for the quick response. I haven’t received the apk (probably due to Gmail), but built and tested the last version of code and the problem is fixed.