[UI] Shadow on the status bar

biociahi

App bar is a solid thing, thus status bar and toolbar must have the same elevation level. This means there should be no shadow on the status bar from the toolbar and vice versa. See the spec. The first patch fixes this glitch.
0_1465474690827_fix-status-bar-shadow.patch

The second patch is a cleanup, it removes redundant attributes: the included layout (accounts_content) does define layout_width and layout_height, no need to repeat them in <include>.
0_1465474701019_remove-redundant-attributes.patch

Screenshot (on Marshmallow) of the issue and the fixed look:

Nothing has changed for pre-Lollipop versions.

rfc2822

Okay Thanks, has been merged.

biociahi

I can’t see those patches in https://gitlab.com/bitfireAT/davdroid/commits/master Am I looking to a wrong place?

rfc2822

They’re part of 317144630cacd1977909b62b304aed446a44b914.

rfc2822

By the way, I think the shadows are different in different activities now. For instance, when I tap an account, the app bar shadow is larger than in the accounts overview. But maybe this was already the case before the patch…

biociahi

Thanks for clarifying.

But maybe this was already the case before the patch…

Yes, it was.

That’s because AccountsActivity uses Toolbar widget while AccountActivity uses old action bar. The former makes a true shadow via the elevation API, the latter–a fake shadow via a drawable. Why Google can’t make them look similar is a different question.