@rfc2822 Thanks for the fast response!
No, there are no real problems with it. I think SSO is a bit easier to configure, though, since you don’t need to enter your credentials another time if you already configured the Nextcloud app.
An idea to improve things could be to maybe make Nextcloud’s Login Flow a bit easier to discover from the DAVx5 app by adding an additional option below extended login when adding a new account directly?
[UI] Shadow on the status bar
App bar is a solid thing, thus status bar and toolbar must have the same elevation level. This means there should be no shadow on the status bar from the toolbar and vice versa. See the spec. The first patch fixes this glitch.
The second patch is a cleanup, it removes redundant attributes: the included layout (
accounts_content) does define
layout_height, no need to repeat them in
Screenshot (on Marshmallow) of the issue and the fixed look:
Nothing has changed for pre-Lollipop versions.
Okay Thanks, has been merged.
I can’t see those patches in https://gitlab.com/bitfireAT/davdroid/commits/master Am I looking to a wrong place?
They’re part of 317144630cacd1977909b62b304aed446a44b914.
By the way, I think the shadows are different in different activities now. For instance, when I tap an account, the app bar shadow is larger than in the accounts overview. But maybe this was already the case before the patch…
Thanks for clarifying.
But maybe this was already the case before the patch…
Yes, it was.
AccountActivityuses old action bar. The former makes a true shadow via the elevation API, the latter–a fake shadow via a drawable. Why Google can’t make them look similar is a different question.